[GR-33602] Bugfixes and improvements for ProgressReporter (#3955). #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakkak
reviewed
Dec 9, 2021
| @@ -1549,19 +1549,10 @@ | |||
| "layout" : { | |||
| "clibraries/" : ["extracted-dependency:substratevm:SVM_HOSTED_NATIVE"], | |||
| "builder/clibraries/" : ["extracted-dependency:substratevm:SVM_HOSTED_NATIVE"], | |||
| "builder/lib/" : ["dependency:com.oracle.svm.native.reporterchelper"], | |||
There was a problem hiding this comment.
@fniephaus this still leaves reporterchelper under a non-platform-dependent folder:
$ find -name "*chelper*"
./lib/svm/builder/clibraries/linux-amd64/liblibchelper.a
./lib/svm/builder/lib/libreporterchelper.so
./lib/svm/clibraries/linux-amd64/liblibchelper.a
There was a problem hiding this comment.
Yes, that's right. We'd only add platform-specific folders for consistency. It would, however, make the consuming Java code unnecessarily complex. That's why I think we can drop the platform-specific folders here. Compared with the other libs, reporterchelper is only needed for the image generation runner, not for the native image binary (hence the distinction between "clibraries" and "lib").
There was a problem hiding this comment.
OK, thanks for the clarification Fabio!
There was a problem hiding this comment.
Thanks for double-checking! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes and improvements for the new Native Image build output (#3955):